url tag being inserted before end of url, etc.

Discussion in 'Site Feedback/Bugs' started by Scrungee, Sep 6, 2013.

  1. Scrungee

    Scrungee Well known for it

    Joined:
    Dec 5, 2010
    Messages:
    16,524
    Location:
    Central England on heavy clay soil
    Ratings:
    +28,997
    As it says in the title, so I had to use the BB Code Editor to sort it out. This is how Xenforo inserts the link with the closing url tag before the !)

    http://www.winesathome.co.uk/forum/...mber-1-Dry-Table-wine-(As-featured-on-the-BBC!)

    Code:
    [URL]http://www.winesathome.co.uk/forum/showthread.php?1562-Wine-number-1-Dry-Table-wine-(As-featured-on-the-BBC[/URL]!)
    Below is the link where I've edited it to get that tag at the end. If anybody clicks on that, copies the url and copies it into a reply they should get the same problem.

    http://www.winesathome.co.uk/forum/...er-1-Dry-Table-wine-(As-featured-on-the-BBC!)



    P.S. Plus I had a problem sending a reply to a Conversation whilst using BB Code Editor, resulting in an error message and duplicated reply.
     
  2. shiney

    shiney President, Grumpy Old Men's Club Staff Member

    Joined:
    Jul 3, 2006
    Messages:
    63,473
    Gender:
    Male
    Occupation:
    Retired - Last Century!!!
    Location:
    Herts/Essex border. Zone 8b
    Ratings:
    +123,760
    Duhhh!!!! :scratch: :hate-shocked:

    Am I missing out on a problem? :heehee:
     
  3. Kristen

    Kristen Under gardener

    Joined:
    Jul 22, 2006
    Messages:
    17,534
    Gender:
    Male
    Location:
    Suffolk, UK
    Ratings:
    +12,669
    Dunno about you Scrungee but I wouldn't have regarded "!" as valid in a URL - I don't doubt that it will work, but I would expect a %xx code instead, and, personally, I think it is reasonable that the editor's best-guess is to assume the URL stops at any "punctuation" type character (rather than processing up to whitespace). We've had similar situations where people cut & paste URLs from emails etc. where they are followed by punctuation and that has, wrongly, got included between the tags (and then the URL doesn't' work of course ...)

    6-of-one and half-a-dozen-of-the-other perhaps?

    Worth being aware of. I find it slightly annoying that the editor converts URLs to BB Code on Paste, rather than on Save, because if I paste in

    www.example.com?MyPrivateID=12345

    then I cannot simply trim the data bit off the end in the editor, I have to also modify the link - which I think would catch less computer savvy people out.
     
  4. Scrungee

    Scrungee Well known for it

    Joined:
    Dec 5, 2010
    Messages:
    16,524
    Location:
    Central England on heavy clay soil
    Ratings:
    +28,997
    It also did it to me this morning by insert the tag before the 364 at the end.
    Code:
    http://www.tesco.com/direct/hp-364-photosmart-printer-ink-cartridge-with-vivera-ink-blister-black/204-2300.prd?pageLevel=&skuId=204-2300&sc_cmp=pcp_GSF_Office Machines & Equipment_204-2300&icid=spiffy_hp 364_204-2300_hp 364
     
  5. Kristen

    Kristen Under gardener

    Joined:
    Jul 22, 2006
    Messages:
    17,534
    Gender:
    Male
    Location:
    Suffolk, UK
    Ratings:
    +12,669
    That URL is definitely wrong - should either have "+" or "%20" instead of spaces ...

    Occupational hazard - editor has to make a choice where it ends.

    Answer is to press the LINK button, paste the URL in there, and then it will generate a correct Link for you (whereas paste it into the message and it will make a best guess where the URL ends ....)
     
    • Agree Agree x 1
    • Scrungee

      Scrungee Well known for it

      Joined:
      Dec 5, 2010
      Messages:
      16,524
      Location:
      Central England on heavy clay soil
      Ratings:
      +28,997
      But it's what the Tesco Direct website actually uses.

      A couple of points:

      1) Changing my User CP Preferences from Rich Text Editor (to default to BB Code input) appears to be causing a proliferation of error messages when trying to upload images, post conversations, etc. It is also preventing me from accessing quotes after highlighting text (the link for the quotes appears but doesn't work) - but it works again if changing back to rich text editor and re-highlighting/clicking on quotes link.

      2) The Link button no longer provides the option of naming a link (I've pointed that out elsewhere), hence my selection of BBC input in (1) above.

      This has all changed with the latest Xenforo 'upgrade'.

      Perhaps somebody else could change their editor in user cp and see if they have the same problem with 'highlighted' quotes? You need to uncheck this box in User CP>Preferences then try 'highlighted' quotes

      GC editor.png
       
    • Kristen

      Kristen Under gardener

      Joined:
      Jul 22, 2006
      Messages:
      17,534
      Gender:
      Male
      Location:
      Suffolk, UK
      Ratings:
      +12,669
      Workaround: type some text, highlight it, press LINK button, paste in the URL

      Not as neat, and certainly not as user-friendly for people not familiar with the ins-and-outs of URLs
       
    • Scrungee

      Scrungee Well known for it

      Joined:
      Dec 5, 2010
      Messages:
      16,524
      Location:
      Central England on heavy clay soil
      Ratings:
      +28,997
      Didn't expect to have to use workarounds on upgraded top notch software and don't see how pasting in using a link will enable that link to be displayed as a named link such as when using
      Code:
      [url=type your name here]link pasted here[/url]
      Anybody checked out trying to use highlighted quotes in BB Code Editor mode as in post #6 above.
       
    • Jiffy

      Jiffy The Match is on Fire

      Joined:
      Aug 25, 2011
      Messages:
      11,609
      Occupation:
      Pyro
      Location:
      Retired Next To The Bonfire in UK
      Ratings:
      +33,525
      It dose not work for me as well, I untick the box,highlighted,quote me, down to the bottom of page( text box) clicked on get quotes(1) and nowt
       
      • Like Like x 1
      • Kristen

        Kristen Under gardener

        Joined:
        Jul 22, 2006
        Messages:
        17,534
        Gender:
        Male
        Location:
        Suffolk, UK
        Ratings:
        +12,669
        OK its not a work around, its how all other forum software, that I have used, works. Its a workaround compared to how it was with the previous editor used here (which apparently caused all sorts of other problems within the system)

        Changing how the core software works, or stating a view on whether method A is better than Method B, needs to take place on Xeno's forum rather than here? Unless its a configurable option there won't be anything RR can do about it.

        I do agree that a LINK box that asks both questions would be better. It could pre-populate the Description bit with any highlighted text in order to be compatible with the more common way of doing things.

        I'm not understanding your example as I think it is the wrong way round?

        Maybe my description wasn't clear? Apologies if we are on the same wavelength, but in case not to clarify:

        Type in

        My Description Here

        highlight that and press LINK button and then paste into the box

        www.example.com

        and the BB code generated will be

        [url=www.example.com]My Description Here[/url]

        It doesn't seem to me to be more difficult than using a popup with two fields, my contention is that the two field box would make it more obvious what is going on, particularly to people who are not very familiar with the process.
         
      Loading...

      Share This Page

      1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
        By continuing to use this site, you are consenting to our use of cookies.
        Dismiss Notice